Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samd: fix device id register masks #1662

Merged
merged 1 commit into from
Oct 30, 2023
Merged

samd: fix device id register masks #1662

merged 1 commit into from
Oct 30, 2023

Conversation

koendv
Copy link
Contributor

@koendv koendv commented Oct 30, 2023 •
edited
Loading

Detailed description

In the Device Identification Register (DID) of samd mcu's, the "series" field is 6 bit, and the "family" field is 5 bit.
This PR sets the correct masks for these fields.

See also #571, #1162 and #1659.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added this to the v2.0 release milestone Oct 30, 2023
@dragonmux dragonmux added the Bug Confirmed bug label Oct 30, 2023
dragonmux
dragonmux approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution!

As a note: We were fine with this being included on the SAMC21 support branch just as a separate commit on the same branch. Given you've done it as a separate PR though, we'll merge as-is.

@dragonmux dragonmux merged commit 0425b88 into blackmagic-debug:main Oct 30, 2023
6 checks passed
@dragonmux dragonmux mentioned this pull request Oct 30, 2023
Merged
6 tasks
@koendv koendv deleted the samd_did_reg branch October 30, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bug
Projects
None yet
Milestone
v2.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@koendv @dragonmux